Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow silencing of REPL output from Jupyter API #450

Merged
merged 4 commits into from Oct 15, 2019

Conversation

@trepidacious
Copy link
Contributor

trepidacious commented Oct 14, 2019

This implements issue #449

trepidacious and others added 4 commits Oct 13, 2019
Some initial tests - needs more
To make MIMA happy mostly…
@alexarchambault

This comment has been minimized.

Copy link
Member

alexarchambault commented Oct 15, 2019

@trepidacious Did you try to add that directly in Ammonite? It may be interesting to have this feature there (and almond would then just read the Ammonite silent ref).

That said, I'm fine merging, until this lands in Ammonite.

@sbrunk

This comment has been minimized.

Copy link
Member

sbrunk commented Oct 15, 2019

@trepidacious just tried this on the plotly example notebook and I think it's a really useful option, thanks! :)

We should add the option to the docs and set it in all example notebooks where it makes sense.
I also agree with @alexarchambault that long-term this option should be exposed in Ammonite itself.

That being said, lgtm!

@sbrunk sbrunk merged commit d5dfccb into almond-sh:master Oct 15, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@trepidacious

This comment has been minimized.

Copy link
Contributor Author

trepidacious commented Oct 16, 2019

Ah great, glad that all looked ok, nice to be able to contribute :)
I hadn't thought of getting the same feature in Ammonite, I'll see about adding an issue there too, that would make a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.