New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localize $@ before eval #5

Merged
merged 2 commits into from Feb 2, 2015

Conversation

Projects
None yet
2 participants
@brummett
Contributor

brummett commented Jan 13, 2015

Keeps these evals from munging $@ in enclosing scopes

@brummett

This comment has been minimized.

Show comment
Hide comment
@brummett

brummett Jan 15, 2015

Contributor

I'd only tested on 5.20, so I didn't see this one.

Pushed a new commit that works on 5.10. Try::Tiny would have probably been a more elegant fix, but I didn't want to introduce a new dependency.

Contributor

brummett commented Jan 15, 2015

I'd only tested on 5.20, so I didn't see this one.

Pushed a new commit that works on 5.10. Try::Tiny would have probably been a more elegant fix, but I didn't want to introduce a new dependency.

@brummett

This comment has been minimized.

Show comment
Hide comment
@brummett

brummett Jan 19, 2015

Contributor

On Thu, Jan 15, 2015 at 8:32 AM, Al Newkirk notifications@github.com
wrote:

Hey Anthony, Thanks for this PR. Unfortunately it isn't passing the test
suite. I plan to look into it soonish, but if you like, you can
investigate
it also. I'll let you know what I find.

I pushed another commit that fixed the problem on older Perls. It was
caused by a bug in Perl that was fixed around 5.12 or 5.14 and I hadn't
tested against an older version.

I also made a pull-request with the first pass at a Regexp type. Let me
know what you think.

-- Tony

Contributor

brummett commented Jan 19, 2015

On Thu, Jan 15, 2015 at 8:32 AM, Al Newkirk notifications@github.com
wrote:

Hey Anthony, Thanks for this PR. Unfortunately it isn't passing the test
suite. I plan to look into it soonish, but if you like, you can
investigate
it also. I'll let you know what I find.

I pushed another commit that fixed the problem on older Perls. It was
caused by a bug in Perl that was fixed around 5.12 or 5.14 and I hadn't
tested against an older version.

I also made a pull-request with the first pass at a Regexp type. Let me
know what you think.

-- Tony

alnewkirk pushed a commit that referenced this pull request Feb 2, 2015

@alnewkirk alnewkirk merged commit 7d8e103 into alnewkirk:master Feb 2, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@brummett brummett deleted the brummett:localize-dollar-at branch Feb 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment