diff --git a/app/Source/Types/WebFile.php b/app/Source/Types/WebFile.php index 45795cc..00c8450 100644 --- a/app/Source/Types/WebFile.php +++ b/app/Source/Types/WebFile.php @@ -2,11 +2,10 @@ namespace App\Source\Types; -use App\Models\Document; +use App\Exceptions\SourceMissingRequiredMetaDataException; use App\Ingress\StatusEnum; +use App\Models\Document; use Illuminate\Support\Facades\Http; -use Illuminate\Support\Facades\Storage; -use App\Exceptions\SourceMissingRequiredMetaDataException; class WebFile extends BaseSourceType { @@ -31,7 +30,7 @@ public function handle(): Document ], [ 'status' => StatusEnum::Complete, - 'content' => $fileContents + 'content' => $fileContents, ] ); diff --git a/app/Transformers/Types/Html2Text.php b/app/Transformers/Types/Html2Text.php index 8bc5a8d..967d8e8 100644 --- a/app/Transformers/Types/Html2Text.php +++ b/app/Transformers/Types/Html2Text.php @@ -3,10 +3,10 @@ namespace App\Transformers\Types; use App\Models\Document; -use App\Models\Transformer; use App\Models\DocumentChunk; -use Soundasleep\Html2Text as Helper; +use App\Models\Transformer; use App\Transformers\BaseTransformer; +use Soundasleep\Html2Text as Helper; class Html2Text extends BaseTransformer { @@ -14,7 +14,7 @@ public function handle(Transformer $transformer): Document { $filePath = $this->document->pathToFile(); - if (str($this->document->guid)->endsWith(".html")) { + if (str($this->document->guid)->endsWith('.html')) { if (! DocumentChunk::query() ->where('document_id', $this->document->id) ->exists()) { diff --git a/database/factories/DocumentFactory.php b/database/factories/DocumentFactory.php index fef1fbb..501d12f 100644 --- a/database/factories/DocumentFactory.php +++ b/database/factories/DocumentFactory.php @@ -2,8 +2,8 @@ namespace Database\Factories; -use App\Models\Source; use App\Ingress\StatusEnum; +use App\Models\Source; use Illuminate\Database\Eloquent\Factories\Factory; /** @@ -31,11 +31,11 @@ public function definition(): array } public function html() -{ + { return $this->state(function (array $attributes) { return [ 'content' => fake()->randomHtml(), - 'guid' => "foo.html" + 'guid' => 'foo.html', ]; }); } diff --git a/tests/Feature/Html2TextTest.php b/tests/Feature/Html2TextTest.php index 71cfedf..2fe79ab 100644 --- a/tests/Feature/Html2TextTest.php +++ b/tests/Feature/Html2TextTest.php @@ -2,19 +2,17 @@ namespace Tests\Feature; -use Mockery; -use Tests\TestCase; use App\Models\Document; use App\Models\Transformer; -use Illuminate\Support\Facades\Http; +use App\Transformers\TransformerTypeEnum; use App\Transformers\Types\Html2Text; use Illuminate\Support\Facades\Storage; -use App\Transformers\TransformerTypeEnum; +use Tests\TestCase; class Html2TextTest extends TestCase { use SharedSetupForPdfFile; - + public function test_parses() { $document = Document::factory()->html()->create(); @@ -22,7 +20,7 @@ public function test_parses() $transformerModel = Transformer::factory()->create([ 'type' => TransformerTypeEnum::Html2Text, ]); - + Storage::fake('projects'); $transformer = new Html2Text($document); @@ -36,5 +34,4 @@ public function test_parses() $this->assertNotNull($content); } - } diff --git a/tests/Feature/Http/Controllers/Html2TextTransformerControllerTest.php b/tests/Feature/Http/Controllers/Html2TextTransformerControllerTest.php index 3d2ae9a..b10fa45 100644 --- a/tests/Feature/Http/Controllers/Html2TextTransformerControllerTest.php +++ b/tests/Feature/Http/Controllers/Html2TextTransformerControllerTest.php @@ -1,8 +1,8 @@ webFileMetaData()->create(); @@ -32,7 +29,7 @@ public function test_gets_file() $document = Document::first(); - $this->assertEquals("foo", $document->content); + $this->assertEquals('foo', $document->content); }