Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Splitting a block level element with enter will cause IE9 and IE10 to crash #474

Closed
albinohrn opened this Issue Mar 20, 2012 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

albinohrn commented Mar 20, 2012

Can be reproduced in the Boilerplate demo by doing the following.

  1. Place the cursor after "FORMATTING"
  2. Hit enter
  3. Now try to navigate with the arrow keys
  4. A dialog will pop up saying that "Internet Explorer has stopped working"

I've reproduced it in IE9 and IE10 it can be reproduced in li, hX, p-tags.
BUT when your next to an inline element the problem doesn't occur, i.e. replace the steps previously shown but now place the cursor after "example content". That works fine.

Contributor

albinohrn commented Mar 21, 2012

Hi again!

when debugging this I have ran in to some more issues with IE9 that may be relevant to the previous issue. When your at the end of an paragraph hitting enter a couple of times to insert a couple of new paragraphs then try to backspace your way up to where you started, you will get stuck...

And an addition to the previous comment. After the first two steps place the cursor, with the mouse, in the next paragraph (the one starting with "Editing any content...") then moving the cursor back to "CONTENT" IE9 and IE10 will crash. So something seems to be wrong with the element that is created in the insertparagraph command.

That all for now.

Have a nice day!

/Albin

Contributor

albinohrn commented Mar 21, 2012

Hi, it's me again :)

This seems to be an IE9/IE10 bug. Their implementation of the domrange seem to be a bit unstable. Therefore rangy has added an configuration option to use the textrange interfaces instead(the same that is used in IE8). For more information se these issues:

http://code.google.com/p/rangy/issues/detail?id=60
http://code.google.com/p/rangy/issues/detail?id=61

The configuration option that have to be changed is "preferTextRange" and should be set to true.

When going through the aloha issues I found this issue #342 this fix might be relevant for that issue as well.

/Albin

@ghost ghost assigned npomaroli Jun 27, 2012

Owner

npomaroli commented Jun 27, 2012

Hi Albin,

thanks for reporting and actually solving this issue!
I just fixed this now for the next release of Aloha Editor by setting "preferTextRange" to true.

br,
Norbert Pomaroli

@npomaroli npomaroli closed this Jun 27, 2012

Contributor

albinohrn commented Jun 27, 2012

You're welcome! I'm glad I could help out.

Have a nice day!

/Albin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment