Skip to content

mahaloBlock() isn't cleaning up after itself #751

karger opened this Issue Oct 7, 2012 · 3 comments

4 participants

karger commented Oct 7, 2012

Invoking alohaBlock() and then mahaloBlock() on a node leaves junk behind on the node, namely class="aloha-block-DefaultBlock" contenteditable="false" data-aloha-block-type="DefaultBlock" as well as an autogenerated id.

This material should be cleaned up during mahaloBlock() since it can mess up tools that use the results.

This is related to issue 459, which notes that aloha()/mahalo() has similar problems.

wimleers commented Oct 8, 2012

Related to aloha/ephemera?


I think mahaloBlock should clean the ephemera content of a specific block instance, and Ephemera.prune should clean all blocks.

wimleers commented Oct 9, 2012

@deliminator Agreed.

@deliminator deliminator was assigned Oct 13, 2012
@evo42 evo42 closed this Oct 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.