Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

All plug-in CSS files should be split in logical parts, to allow for custom UI styling #765

Closed
wimleers opened this Issue Oct 15, 2012 · 1 comment

Comments

Projects
None yet
3 participants
Contributor

wimleers commented Oct 15, 2012

Look at src/plugins/image/css/image.css.

The majority of this CSS file (starting at the top) is intended for the Image plug-in's UI. That's not actually needed (and thus unnecessary bytes are sent) when you use a custom UI. Once we migrate to aloha/ui-a-la-carte (#747), that will become commonplace.

The minority of this CSS file (starting at the bottom) is intended for "in-editable styling" (What's the right term?). These are not (or at least arguably less) dependent on the UI. This should live in a separate CSS file.

Thoughts?

Contributor

deliminator commented Oct 16, 2012

Splitting the css into logical parts would be a good thing.

src/plugins/image/css/image-ui-default.css
src/plugins/image/css/image-ui-bootstrap.css
src/plugins/image/css/image-common.css

@ghost ghost assigned deliminator Oct 18, 2012

@evo42 evo42 closed this Oct 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment