Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Sourceview plugin #501

wants to merge 20 commits into


None yet
3 participants

petrosalema commented Apr 6, 2012

Introducing sourceview plugin into main code base.

The sourceview plugin allows for visualizing the current selection at the DOM/markup level in the sidebar.

  1. [DONE] obey coding guidelines http://aloha-editor.org/builds/development/latest/doc/guides/output/style_guide.html
  2. [N/A] write JSLint compliant code
  3. [DONE] write JSDoc for every method you touched during your implementation
  4. [DONE] write a human-readable :) [[changelog]] entry that describes your change
  5. [N/A] add a qunit test (if it makes sense) and/or document the steps to manually test it (in a separate guides page)
  6. [DONE] test your changes in Internet Explorer 7, 8, 9 and the latest Firefox and latest Chrome
  7. [N/A] document your changes in a guide
  8. [DONE] include this list in a your pull request

Petro Salema and others added some commits Apr 4, 2012

Petro Salema Fixing `processCursor()' method. 1ff0ce3
Petro Salema Added check in `jumpBlock()' to accomodate invisible white spaces. 2eb0525
Petro Salema Fixed checks for considering what offset is the safest in IE 8 and ol…
…der to reckon that a selection is at the front position of a text container
Petro Salema Adding documentation for workaround for IE 7, 8 cursor positioning bug. 7d8aafe
Petro Salema Minor update on inline documentation 1f0984d
Petro Salema Changed `nextNode()' and `prevNode()' to `nextVisibleNode()' and `pre…
…vVisibleNode()' respectively
@salemapetro salemapetro Updating inline documentation a bit 20e60ab
Petro Salema function `jumpBlock()' will land in available editable node if one ex…
…ists next to an adjacent non-editable block.
Petro Salema Added more checks for invisible elements. Restructured algorithm to a…

expensive work in iE.  Added cleanup of placeholders.
Petro Salema Adding manual test for block caret positioning 90ec13f
Petro Salema Fixed skipping of propping <br> tags. b345b46
Petro Salema Moved helper function into `define()' closure. 36135ed
Petro Salema Added support to compareDocumentPosition for older versions of IE.
jQuery's `find()' method was throwing errors in IE 7, and 8.
Petro Salema Cleaning up `jumpBlock()' a little 3f2fc3c
Petro Salema Adding changelog entries c7f2015
Petro Salema We will no longer handle the UP and DOWN cursor key through `processC…
Petro Salema Adds a guard in `execCommand()' to prevent a out of bounds index exce…
Petro Salema Adds changelog entries 2e5c9b3
Petro Salema Skipping over all invisible content element, not just text. 1484b1c
Petro Salema Adding sourceview plugin 28ecb62

evo42 commented Apr 18, 2012

can you make the pull request to be green again? thx :-)

@petrosalema petrosalema closed this May 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment