/spider

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli should accept files in different directory. #118

Open
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alinbsp @coveralls @Namek @alongubkin
@alinbsp

alinbsp commented Dec 5, 2014

Hi,
Is there a reason for using the basename instead of the full file name here?
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 5, 2014

Coverage Status

Coverage remained the same when pulling a41b60b on alinbsp:directory_arg into d501b66 on alongubkin:master.

coveralls commented Dec 5, 2014

Coverage Status

Coverage remained the same when pulling a41b60b on alinbsp:directory_arg into d501b66 on alongubkin:master.
@Namek

This comment has been minimized.

Show comment
Hide comment
@Namek

Namek Dec 6, 2014

Collaborator

@alinbsp How does it affect the way it works?
Collaborator

Namek commented Dec 6, 2014

@alinbsp How does it affect the way it works?
@alongubkin

This comment has been minimized.

Show comment
Hide comment
@alongubkin

alongubkin Dec 6, 2014

Owner

Is there a reason for using the basename instead of the full file name here?

Yes - source maps.
Owner

alongubkin commented Dec 6, 2014

Is there a reason for using the basename instead of the full file name here?

Yes - source maps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment