Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refined types to configuration #120

Merged
merged 3 commits into from Sep 8, 2017

Conversation

@alonsodomin
Copy link
Owner

commented Sep 7, 2017

No description provided.

Antonio Alonso Dominguez added some commits Sep 7, 2017

Antonio Alonso Dominguez
Antonio Alonso Dominguez
@codecov-io

This comment has been minimized.

Copy link

commented Sep 8, 2017

Codecov Report

Merging #120 into master will decrease coverage by 0.26%.
The diff coverage is 64.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   60.74%   60.48%   -0.27%     
==========================================
  Files         119      119              
  Lines        2290     2199      -91     
  Branches       65       62       -3     
==========================================
- Hits         1391     1330      -61     
+ Misses        899      869      -30
Impacted Files Coverage Δ
...ain/scala/io/quckoo/testkit/QuckooActorSuite.scala 100% <ø> (ø) ⬆️
...r/src/main/scala/io/quckoo/cluster/boot/Boot.scala 0% <ø> (ø) ⬆️
...o/quckoo/cluster/registry/RegistryHttpRouter.scala 91.17% <ø> (ø) ⬆️
.../scala/io/quckoo/reflect/ArtifactClassLoader.scala 60.71% <ø> (ø) ⬆️
...d/src/main/scala/io/quckoo/reflect/Reflector.scala 50% <ø> (ø) ⬆️
...ed/src/main/scala/io/quckoo/resolver/package.scala 100% <ø> (ø) ⬆️
...scala/io/quckoo/reflect/ReflectorInterpreter.scala 50% <ø> (ø) ⬆️
.../src/main/scala/io/quckoo/cluster/core/Topic.scala 0% <ø> (ø) ⬆️
...rc/main/scala/io/quckoo/cluster/config/model.scala 50% <ø> (ø) ⬆️
shared/src/main/scala/io/quckoo/reflect/ops.scala 33.33% <ø> (ø) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ff5b0...717f2b3. Read the comment docs.

@alonsodomin alonsodomin merged commit 4ae4113 into master Sep 8, 2017

3 checks passed

codecov/patch 64.91% of diff hit (target 60.74%)
Details
codecov/project Absolute coverage decreased by -0.26% but relative coverage increased by +4.16% compared to 68ff5b0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alonsodomin alonsodomin deleted the refined branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.