Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kamon #127

Merged
merged 4 commits into from Feb 10, 2018

Conversation

@alonsodomin
Copy link
Owner

commented Feb 10, 2018

And rebuild the standalone setup with Prometheus monitoring

@codecov-io

This comment has been minimized.

Copy link

commented Feb 10, 2018

Codecov Report

Merging #127 into master will decrease coverage by 0.01%.
The diff coverage is 84.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage    60.5%   60.49%   -0.02%     
==========================================
  Files         119      120       +1     
  Lines        2198     2187      -11     
  Branches       72       70       -2     
==========================================
- Hits         1330     1323       -7     
+ Misses        868      864       -4
Impacted Files Coverage Δ
...r/src/main/scala/io/quckoo/cluster/boot/Boot.scala 0% <ø> (ø) ⬆️
...ala/io/quckoo/cluster/registry/PersistentJob.scala 66.66% <ø> (-3.83%) ⬇️
...rc/main/scala/io/quckoo/cluster/QuckooFacade.scala 0% <0%> (ø) ⬆️
...er/src/main/scala/io/quckoo/worker/boot/Boot.scala 0% <0%> (ø) ⬆️
.../quckoo/cluster/scheduler/ExecutionLifecycle.scala 91.17% <100%> (-0.13%) ⬇️
...cala/io/quckoo/worker/executor/ProcessRunner.scala 100% <100%> (ø) ⬆️
...hared/src/main/scala/io/quckoo/kamon/package.scala 100% <100%> (ø)
.../scala/io/quckoo/cluster/scheduler/TaskQueue.scala 74.49% <100%> (ø) ⬆️
...in/scala/io/quckoo/cluster/registry/Registry.scala 63.76% <100%> (-0.52%) ⬇️
.../src/main/scala/io/quckoo/worker/core/Worker.scala 82.35% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb0157...696bef0. Read the comment docs.

@alonsodomin alonsodomin merged commit bc5b2e0 into master Feb 10, 2018

3 checks passed

codecov/patch 84.84% of diff hit (target 60.5%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +24.33% compared to fdb0157
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alonsodomin alonsodomin deleted the upgrade_kamon branch Feb 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.