Compatibility with whitespace mode (in Emacs 23) #1

Closed
sheijk opened this Issue May 26, 2011 · 11 comments

Projects

None yet

3 participants

@sheijk
sheijk commented May 26, 2011

fci-mode does not play nicely with the whitespace mode of Emacs 23:

  1. M-x, fci-mode
  2. M-x, whitespace-mode
  3. M-x, whitespace-toggle-options, S
  4. M-x, whitespace-toggle-options, N
    When pressing ? in whitespace-toggle-option the N,B,S options on the bottom should be marked

Now between the last character of a line and the fill-column non-existing spaces are highlighted and all end-of-line-markers appear after the fill-column.

Tried using GNU Emacs 23.3.1 (x86_64-apple-darwin, NS apple-appkit-1038.35)

@alpaker
Owner
alpaker commented May 27, 2011

Thanks. I know about this already, but haven't decided on the right fix
yet. (Whitespace mode is very difficult--much more than hl-line-mode.)
Hopefully in the next week or two I'll have a fix.

Best,

Alp

On Thu, May 26, 2011 at 5:08 PM, sheijk <
reply@reply.github.com>wrote:

fci-mode does not play nicely with the whitespace mode of Emacs 23:

  1. M-x, fci-mode
  2. M-x, whitespace-mode
  3. M-x, whitespace-toggle-options, S
  4. M-x, whitespace-toggle-options, N
    When pressing ? in whitespace-toggle-option the N,B,S options on the bottom
    should be marked

Now between the last character of a line and the fill-column non-existing
spaces are highlighted and all end-of-line-markers appear after the
fill-column.

Tried using GNU Emacs 23.3.1 (x86_64-apple-darwin, NS apple-appkit-1038.35)

Reply to this email directly or view it on GitHub:
#1

@alpaker
Owner
alpaker commented May 27, 2011

One further question: Do you use fci-mode with rule style or shading style?
I can fix things very easily for shading style, and I'm considering
dropping support for rule style.

Alp

On Thu, May 26, 2011 at 9:14 PM, Alp Aker alptekin.aker@gmail.com wrote:

Thanks. I know about this already, but haven't decided on the right fix
yet. (Whitespace mode is very difficult--much more than hl-line-mode.)
Hopefully in the next week or two I'll have a fix.

And if I could ask you a question, since I believe you're German: Spricht
man auf Deutsch von "der whitespace-mode", "der hl-line-mode", usw.? Oder
braucht man ein anderes Substantiv?

Best,

Alp

On Thu, May 26, 2011 at 5:08 PM, sheijk <
reply@reply.github.com>wrote:

fci-mode does not play nicely with the whitespace mode of Emacs 23:

  1. M-x, fci-mode
  2. M-x, whitespace-mode
  3. M-x, whitespace-toggle-options, S
  4. M-x, whitespace-toggle-options, N
    When pressing ? in whitespace-toggle-option the N,B,S options on the
    bottom should be marked

Now between the last character of a line and the fill-column
non-existing spaces are highlighted and all end-of-line-markers appear after
the fill-column.

Tried using GNU Emacs 23.3.1 (x86_64-apple-darwin, NS
apple-appkit-1038.35)

Reply to this email directly or view it on GitHub:
#1

@sheijk
sheijk commented May 28, 2011

I'm currently using rule style. Personally I consider this the killer feature for fci-mode as it fills one of the painful gaps in Emacs so I'd prefer it to live on :)

@sheijk sheijk closed this May 28, 2011
@sheijk sheijk reopened this May 29, 2011
@jlisee
jlisee commented Jun 2, 2011

I also consider rule style to be the killer feature of this mode. The shading style is just a little too intrusive.

@alpaker
Owner
alpaker commented Jun 2, 2011

Thanks for the feedback. I'll keep rule style as an option, then. (I shouldn't make it sound like that's more work. Contrary to my expectations, shading style is presenting more problems with whitespace-mode than rule style.)

@jlisee
jlisee commented Jun 2, 2011

Thanks for the fast response, I am really liking this mode and I am hoping to use it with whitespace mode for easy tab detection.

@alpaker
Owner
alpaker commented Jun 7, 2011

Sorry this is taking longer than expected. I've been developing on 24, but it turns out that the older display routines in 22 and 23 are incompatible with the fix I came up with (in addition, there's a nasty bug in the Mac OS X port that I discovered in the course of doing this that I've got to work around). I think I've come up with a general solution, but I've still got to implement it.

@jlisee
jlisee commented Jun 9, 2011

Hey no problem, thanks for maintaining backwards compatibility with emacs 23.

@alpaker
Owner
alpaker commented Jun 13, 2011

Ok. I've finally got the new version up. I had to rework things at a pretty basic level, but it should be much more generally robust. Let me know how it works.

(I'm dropping support for shading style, at least for the moment, because I can't figure out how to make that work with whitespace mode without either (a) patching the C sources, or (b) hacking about twenty different Lisp functions used by the basic display routines.)

@alpaker alpaker closed this Jun 17, 2011
@sheijk
sheijk commented Jul 10, 2011

Just tried version 1.67. Most things work fine, although line endings (the $ symbols, N option in the original post) are still displayed after the fill-column. Anyway, it is a lot more useful now, thanks for the fixes!

@alpaker
Owner
alpaker commented Jul 10, 2011

That's strange. I can't reproduce the problem with the line endings, even using a version very close to yours (GNU Emacs 23.3.50.1, built on x86_64-apple-darwin10.5.0, with NS apple-appkit-1038.35).

Could you try to reproduce the problem starting from Emacs -Q (or with and empty .emacs file)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment