Migrate linting from flake8+isort to ruff#1033
Merged
Merged
Conversation
Replace `flake8`, `flake8-bugbear`, and `isort` with `ruff` (rules `E`, `W`, `F`, `B`, `I`). `black` remains the sole formatter; `ruff format` is not used. - Delete `.flake8`; add `[tool.ruff]` sections to `pyproject.toml` - Update `Makefile`: fold `flake8` target into `format`/`format-check` - Update `tox.ini`, `AGENTS.md`, `CONTRIBUTING.md`, and skill files - Fix pre-existing violations surfaced by `ruff`: `E713` (auto-fix), `B007` (rename to `_dirpath`), `B024` (remove spurious `ABC` from `CommandOptions`), `B905` (add `strict=True` to `zip()` calls) - Suppress `B904` globally (pre-existing raise-without-from violations) - Deduplicate validate/commit steps in mypy sub-skills; point to parent `SKILL.md` as the single source of truth
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
=======================================
Coverage 74.36% 74.36%
=======================================
Files 90 90
Lines 12496 12496
Branches 2193 2193
=======================================
Hits 9293 9293
Misses 2682 2682
Partials 521 521 ☔ View full report in Codecov by Sentry. |
LanderOtto
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
flake8,flake8-bugbear, andisortwithruff(rulesE,W,F,B,I).blackremains the sole formatter;ruff formatis not used..flake8; add[tool.ruff]sections topyproject.tomlMakefile: foldflake8target intoformat/format-checktox.ini,AGENTS.md,CONTRIBUTING.md, and skill filesruff:E713(auto-fix),B007(rename to_dirpath),B024(remove spuriousABCfromCommandOptions),B905(addstrict=Truetozip()calls)B904globally (pre-existing raise-without-from violations)SKILL.mdas the single source of truth