Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
The browser based tests are still needed to identify Firefox versions with a known flash bug that interferes with SWFObject. This can't easily be handled using feature detection.
There are also MSIE tests which add classes for styling, the default styles use these to trigger
Includes whitespace changes, recommend reviewing using
EDIT: Tested on Static and https://wwww.gov.uk/government/news/ramadan-2015-david-camerons-message
Omitting early regexp tests would create false positives. * Put back opera and chrome regexps * Use user agents from https://github.com/jquery/jquery/blob/1.7.2/test/data/ua.txt * Expose the UA test for testing (it was previously exposed in jQuery)
The changes look good to me, especially the testing
I checked this out locally to run the tests (with
I think I may be missing a setup step, but i'm assuming they pass locally for you?
It would be good to have CI for this repo, not a blocker for this PR if the tests do pass, but worth adding for general confidence, given this a repo we touch irregularly.
(Top commits btw, this was a pleasure to review)
@dsingleton The unrelated test failure is also failing on master, and is probably related to a change in an external Vimeo API since the tests were written – which I discussed with @tombye. I've left out fixing that test from this PR because it's unrelated, but it should be put right.
This is a repo we've previously pushed upstream (and I'd like to push these changes too), which is something to consider when setting up CI.
jQuery.history is used only by jQuery.tabs. It's use of the deprecated jQuery.browser is blocking the upgrade of jQuery. There is a plan to design away tabs. Replace uses with a `historyBrowserShim`. The same approach as alphagov/Accessible-Media-Player#7 * Refer to local shim rather than jQuery