Permalink
Commits on Sep 22, 2016
  1. Merge pull request #326 from alphagov/add-scheduled-downtime-notice

    Add notice about scheduled maintenance
    alexmuller committed on GitHub Sep 22, 2016
  2. Add notice about scheduled maintenance

    We're going to be doing some work on EFG on Tuesday.
    alexmuller committed Sep 22, 2016
Commits on Sep 19, 2016
  1. Lump sum repayment validation fix

    Handle when initial draw amount is not set. Was raising an exception
    when blank.
    sidane committed Sep 12, 2016
  2. Fetch config from the environment

    Right now these files are overwritten at deploy time with their
    actual production values. It's nicer to fetch these values from
    the environment rather than overwriting files.
    alexmuller committed with sidane Sep 16, 2016
  3. Add initializer to filter exception notifications

    This is included with the app at deploy time. I can't think of any reason
    to not have it in the repo.
    alexmuller committed with sidane Sep 16, 2016
  4. Remove default values for secrets

    We very nearly had a security incident with EFG because of the way we add
    initializers during deployment. We ended up almost using the public version
    of the `secret_key` in production.
    
    To stop this from happening, the app must read it's config from the
    environment. This may mean that you have to adjust your development
    environments to provide these variables.
    alexmuller committed with sidane Sep 15, 2016
Commits on Aug 8, 2016
  1. Mixin FactoryGirl methods in RSpec

    Will allow for less verbose specs by calling `create`, `build` etc
    directly
    sidane committed Aug 2, 2016
Commits on Aug 5, 2016
  1. Remove Phase 5 state aid calculation from loan entry

    Phase 5 loans and earlier required generating premium schedule at Loan
    Entry to calculate State Aid. As there can no longer be new loans in
    Phase 6 or earlier, this functionality can be safely removed.
    sidane committed Aug 2, 2016
Commits on Aug 4, 2016
  1. Add formulaic gem

    sidane committed Jul 13, 2016
  2. Add Pry

    sidane committed Jul 12, 2016
Commits on Jul 11, 2016
  1. Upgrade theubyracer gem

    sidane committed Jul 11, 2016
  2. Dry up loan change presenters.

    nickcharlton committed with sidane Jun 16, 2016
  3. This test is not valuable

    sidane committed Jun 16, 2016
  4. Always show Capital Repayment Holiday fields.

    Except in the Capital Repayment Change, which already has it.
    sidane committed Jun 16, 2016
  5. Restore Tranche fields to loan change forms.

    Incorrect tranches were being carried forward when generating new premium
    schedules.
    sidane committed Jun 16, 2016
Commits on Jun 29, 2016
  1. Handle when recovery debt is 0

    NaN error was being raised when the distribution_of_remaining_securities
    was all zeroes.
    sidane committed Jun 29, 2016
Commits on Jun 16, 2016
  1. Loan change date of change cannot be in the future

    sidane committed Jun 16, 2016
  2. Additional lump sum repayment validation

    Ensures outstanding balance doesn’t exceed the remaining amount on the
    loan.
    sidane committed Jun 14, 2016
  3. Ensure various date fields cannot be in the future

    Loan#cancelled_on
    Loan#no_claim_on
    Loan#dti_demanded_on
    Loan#remove_guarantee_on
    Recovery#recovered_on
    sidane committed Jun 14, 2016
  4. New loans should use current Phase rules

    Previously new loans were falling back to Phase 1 rules so the correct 
    phase specific validations weren’t being applied to new loans until 
    later in the loan lifecycle (i.e. loan entry).
    sidane committed Jun 9, 2016
  5. Expose Loan Status Amendment Fields in the export.

    nickcharlton committed with sidane Jun 15, 2016
  6. Always set legacy schedule calculation to false.

    This solves an issue where old loans would have new premium schedules
    using the legacy calculation fix.
    sidane committed Jun 15, 2016
  7. Data Migration to fix premium schedule calculation

    PR #270 (https://git.io/FD25) duplicates premium schedules when making a
    loan change. This carries forward legacy_premium_calculation value
    of 1 for old schedules where it shouldn't (all new premium schedules
    should use the new premium schedule calculation).
    
    This restores all affected schedules since then to the correct value.
    sidane committed Jun 6, 2016
Commits on Jun 15, 2016
  1. Update zeroed out created_at and updated_at values

    Database records in various tables that existed prior to migrating to
    this app had their `created_at` and `updated_at` set to 0000-00-00
    00:00:00.
    
    When the extractor runs it converts these datetime to the current
    datetime (i.e. the time the extractor runs). This causes problems when
    working with the data locally, like when querying data by creation
    date.
    
    This adds a data migration which updates all those zeroed out values to
    the midnight of the morning when this app was launched.
    sidane committed Jun 15, 2016
Commits on Jun 13, 2016
  1. Add the Devise test helpers to view specs.

    nickcharlton committed Jun 9, 2016
  2. Show the lender in the loans summary view.

    This also adds some basic tests to ensure the summary itself is actually being
    shown.
    nickcharlton committed Jun 9, 2016
  3. Show the lender in Loan States.

    This shows the lender, unless the user is of type LenderUser. This means that
    you won't see your own company, but will see all the companies if you have
    another type of user.
    nickcharlton committed Jun 8, 2016
  4. Ensure additional draw downs have amount and month

    On a Premium Schedule, an additional draw down could be defined with an
    amount but no month or a month but no amount. This ensures that both
    values are present.
    sidane committed Jun 9, 2016
  5. Do not link to premium schedule form as Cfe User

    Cfe users cannot generate premium schedules, only lender users can.
    Disable the premium schedule button for Cfe users when the loan does
    not yet have a premium schedule.
    sidane committed Jun 8, 2016