You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Worth noting that the typeahead used to have a lot more inline styling relating to critical functionality and usability (like overlaying using absolute positioning), but it was abstracted out in the CSS.
There's pros and cons to either approach with some advocating that the best would be to just pull everything into CSS but I think the current way it works is alright.
Seems like current approach is good for users because consumers can't accidentally hide the information in an odd way but it means that this component must be updated which seems reasonable because then others have an easy way to update.
I suppose you could argue that you only should expose things that can be themed so this may be fine?
https://github.com/alphagov/accessible-typeahead/blob/enhance-select-element/src/status.jsx#L42
The text was updated successfully, but these errors were encountered: