Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not make assumptions about files in HMRC PAYE task #585

Merged
merged 2 commits into from Aug 3, 2018
Merged

Conversation

barrucadu
Copy link
Contributor

The documented list of files does not match the reality.

This also makes it much easier to load all the current files into the asset manager:

for file in *; do
    sudo -udeploy govuk_setenv asset-manager bundle exec rake govuk_assets:create_hmrc_paye_asset[$file]
done

Trello card

The documented list of files does not match the reality.
Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add a Rake task that basically does the same as for * in file and you can upload a whole directory in one go?

Might also be worth adding some logging to let the user know it's working correctly.

@barrucadu
Copy link
Contributor Author

I've only made it do all zip files, as the xml file needs its file name changing when uploaded.

@barrucadu
Copy link
Contributor Author

create_or_replace_whitehall_asset already prints out on-disk filenames and legacy URL paths as it uploads things, so I don't think there's a need for extra logging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants