Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove start page from Calculators #188

Merged
merged 5 commits into from Jun 15, 2017
Merged

Remove start page from Calculators #188

merged 5 commits into from Jun 15, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 13, 2017

Depends on #187 and alphagov/publisher#629 tasks being run

Now Publisher and Frontend handle the start page for child benefit tax calculator (it's now a transaction), remove all traces of it.

  • Remove template, tests and routes
  • Remove old redirects from 2013
  • Stop sending anything to search (only the start page should be in search, like other services)
  • Only publish a content item for the calculator form
  • Request the calculator form content item (eg /main) (this changes the breadcrumb to the one defined on that content item, currently empty – as discussed with @carvil)
@fofr fofr requested review from ikennaokpala and chao-xian Jun 13, 2017
@fofr fofr changed the title [Do not merge] Remove start page from Calculators Remove start page from Calculators Jun 14, 2017
Copy link
Contributor

@ikennaokpala ikennaokpala left a comment

I have reviewed these changes and tried to test on integration as well via [1].

The changes appear ok but need to validate this against integration. Any idea why rummager is failing.. I think it may be something to do with the content id.

[1] https://deploy.integration.publishing.service.gov.uk/job/Deploy_App/644/console

@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 14, 2017

@ikennaokpala All the rummager code has been deleted, so the deploy task is trying to run a rake task that no longer exists.

@ikennaokpala
Copy link
Contributor

@ikennaokpala ikennaokpala commented Jun 14, 2017

@fofr Ahh right!! How can this be skipped ?

@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 14, 2017

@ikennaokpala
Copy link
Contributor

@ikennaokpala ikennaokpala commented Jun 14, 2017

@fofr I have raised this PR

Copy link
Contributor

@ikennaokpala ikennaokpala left a comment

I have reviewed the changes for this PR and it LGTM 👍 .

I have also tested this branch on integration (i.e [1] and [2]) and found that the start page for child-benefit-tax-calculator returning a 404.

The 404 was due to the none existence of a defined transaction start page from publisher.
At the time of testing I found that staging [3] and production [4] have transaction start page already defined for child-benefit-tax-calculator, hence it is only a matter of time for integration to catch up with staging and production.

[1] https://deploy.integration.publishing.service.gov.uk/job/Deploy_App/655/console
[2] https://errbit.integration.publishing.service.gov.uk/apps/5361171a0da115f1e0009de2
[3] https://www-origin.staging.publishing.service.gov.uk/api/content/child-benefit-tax-calculator
[4] https://gov.uk/api/content/child-benefit-tax-calculator

fofr added 5 commits Jun 9, 2017
The start page has been switched to a transaction in Publisher and is
rendered by alphagov/frontend.

* Remove template, tests and routes
* Remove old redirects from 2013
Publisher handles the start page and that will publish the start page,
with all its content, to Rummager.
* Only publish a content item for the calculator form
This removes the breadcrumb from the top of the service page, replacing
it with a Home link.

If the calculator form content item gets a breadcrumb added to it, then
it will begin to show again.
* Calculators is just one calculator
* It renders just one page: /child-benefit-tax-calculator/main
@fofr fofr force-pushed the remove-start-page branch from 9eae568 to ef677ba Jun 14, 2017
@fofr fofr merged commit 8925e36 into master Jun 15, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the remove-start-page branch Jun 15, 2017
rubenarakelyan added a commit to alphagov/govuk-puppet that referenced this pull request Jun 15, 2017
This commit updates the healthcheck path for the calculators app by appending `/main` to the path to match the changes made in alphagov/calculators#188.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.