Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove non-word characters from event UIDs #784
Thanks again for your work on the bank holiday calendar UID update.
This is a simple piece of defensive programming after observing this UID in the latest production .ics output:
After my proposed change the UID line will come out as:
Removing non-word characters seemed like the best way to avoid accounting for the text escaping rules in the ICS format spec. Without this change, an event name with a
Hope this helps!
This Pull Request is fine. The checks are tracked by commit, so the branch doesn't matter.
On Thu, 13 Feb 2020, 11:15 Christopher Baines, ***@***.***> wrote: If you want me to close this and open a PR from that branch let me know. (Alternatively if you know a way to switch the "head" branch of an open PR I'd be interested to hear) This Pull Request is fine. The checks are tracked by commit, so the branch doesn't matter. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#784?email_source=notifications&email_token=AALVRPHROLTLWNGNESBCIZ3RCUTWRA5CNFSM4KUESYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELULJ3A#issuecomment-585676012>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALVRPCJC6TKZKSXXBLUBA3RCUTWRANCNFSM4KUESYZA> .