Skip to content
This repository has been archived by the owner. It is now read-only.

Re-hang the bunting so it looks alright #87

Merged
merged 3 commits into from May 5, 2015
Merged

Re-hang the bunting so it looks alright #87

merged 3 commits into from May 5, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 5, 2015

Bunting was not showing correctly on a bank holiday. It started from the left side of the grid.

This PR is in combination with changes to static, which remove the bunting styles that were over there.

  • Hang bunting across full page width by positioning absolutely
  • Tweak the top margins for content and related links
  • Use the same media queries for modifying margins as used for hiding the bunting

There's a white space commit, so I suggest reviewing with ?w=1

https://www.pivotaltracker.com/story/show/93891364

cc @futurefabric @edds @wryobservations

Before

screen shot 2015-05-05 at 16 12 00

After

screen shot 2015-05-05 at 16 09 53

fofr added 3 commits May 5, 2015
Bunting was not showing correctly on a bank holiday. It started from
the left side of the grid.

In combination with changes to static, which remove the bunting styles
there, re-hang the bunting so it looks alright.

* Position bunting absolutely
* Tweak the top margins for content and related links
We were hiding the bunting with one query and shifting margins with
another, this led to a situation at some viewports where the bunting
would disappear but the margins would still be larger than they needed
to be.
@JordanHatch
Copy link
Contributor

@JordanHatch JordanHatch commented May 5, 2015

👍 🎉

alicebartlett added a commit that referenced this pull request May 5, 2015
Re-hang the bunting so it looks alright
@alicebartlett alicebartlett merged commit 8797037 into master May 5, 2015
1 check passed
1 check passed
default "Build #11 succeeded on Jenkins"
Details
@alicebartlett alicebartlett deleted the fix-bunting branch May 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.