Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page improvements #1479

Merged
merged 2 commits into from Feb 3, 2020
Merged

Landing page improvements #1479

merged 2 commits into from Feb 3, 2020

Conversation

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Feb 3, 2020

What

  • Move multiple uses of govuk-width-container to a common parent
  • Remove uses of full-page-width-wrapper
  • Attempt to standardise landing page section spacing (previously, some sections applied both bottom and top spacing).

There should be no visual changes as a result of this PR.
Example: https://govuk-collec-landing-pa-m9vnq4.herokuapp.com/transition

Note: this isn't a full refactor, but what is needed to add a new section to the page in a follow-up PR. I'll do a clean-up at some point as it looks like there could be a fair amount of repetition/unused styles left over from previous iterations of the landing page.

@bevanloon bevanloon temporarily deployed to govuk-collec-landing-pa-m9vnq4 Feb 3, 2020 Inactive
@vanitabarrett vanitabarrett marked this pull request as ready for review Feb 3, 2020
@vanitabarrett vanitabarrett requested review from huwd, koetsier and laurentqro Feb 3, 2020
@huwd
huwd approved these changes Feb 3, 2020
@vanitabarrett vanitabarrett merged commit 2a72db9 into master Feb 3, 2020
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@vanitabarrett vanitabarrett deleted the landing-page-improvements branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.