Follow up css updates #215

Merged
merged 5 commits into from Jan 12, 2017

Projects

None yet

3 participants

@carvil
Member
carvil commented Jan 11, 2017

This is a follow up PR from #213

cc/ @fofr @nickcolley @tijmenb @carolinegreen

@fofr
Member
fofr commented Jan 11, 2017

Does the wraith output look the same as before?

@fofr
Member
fofr commented Jan 11, 2017

The email sign up content is indented strangely:

screen shot 2017-01-11 at 15 02 14

@carvil
Member
carvil commented Jan 11, 2017 edited

@fofr that's true. I didn't know if that was on purpose, though. The latest page also has that indentation. Should the alignment be like in the other pages (i.e. aligned to the breadcrumbs)?

@fofr
Member
fofr commented Jan 11, 2017

Yep, breadcrumb and content should align on all viewports.

carvil added some commits Jan 11, 2017
@carvil carvil Convert HTML comment to ERB comment
This copy doesn't need to be in the markup.
a3d79a7
@carvil carvil Use measurement variables b8a1c43
@carvil carvil Remove grid-row from markup 361bbb2
@carvil carvil Fix layout of content in email signup page 55d3df7
@carvil carvil Fix layout of subtopic and latest pages
We have introduced the new `grid-row` class in order to modernise the layout of
both the subtopic and latest pages.

This makes it look a bit different from the current version live.

This was checked with @alextea
b9fe689
@carvil
Member
carvil commented Jan 11, 2017

@fofr We've updated the CSS to fix the email signup page.

In the process, we also fixed the latest page and came across other issues. Together with @alextea we changed a few things in topic and latest pages (e.g. the width of the from organisations). We introduced the grid-row class there and it does look a bit different, but now uses the new CSS we should be using.

We have also started using standard measurements in some places (e.g. padding in titles) instead of hardcoded pixels. This will explain some of the differences you will see in the wraith output.

Here are the latest tests: https://carvil.github.io/collections-wraith-tests/shots/gallery.html

What do you think?

@nickcolley

Looks like the 'is anything wrong' is misaligned now

screen shot 2017-01-11 at 17 27 03

@fofr
Member
fofr commented Jan 11, 2017

@nickcolley That's a known issue with government-frontend too. It's a tricky one that I think is acceptable for this PR.

@carvil
Member
carvil commented Jan 12, 2017

@fofr / @nickcolley the issue with the "Is there anything wrong with this page?" div comes from static and govuk_frontend_toolkit I think.

The wrapper div extends %site-width-container, which in turn adds left/right margin of size $gutter in the tablet viewport (more details here).

I don't think this issue should be fixed in this PR.

Are you ok to merge this change?

@fofr
fofr approved these changes Jan 12, 2017 View changes
@carvil carvil merged commit 7181eeb into master Jan 12, 2017

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details
@carvil carvil deleted the follow-up-css-updates branch Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment