This is a follow up PR from #213
cc/ @fofr @nickcolley @tijmenb @carolinegreen
Does the wraith output look the same as before?
@fofr Yes, here is the link: https://carvil.github.io/collections-wraith-tests/shots/gallery.html
The new commit is here: carvil/collections-wraith-tests@39f9ea7
The email sign up content is indented strangely:
@fofr that's true. I didn't know if that was on purpose, though. The latest page also has that indentation. Should the alignment be like in the other pages (i.e. aligned to the breadcrumbs)?
Yep, breadcrumb and content should align on all viewports.
Convert HTML comment to ERB comment
This copy doesn't need to be in the markup.
Use measurement variables
Remove grid-row from markup
Fix layout of content in email signup page
Fix layout of subtopic and latest pages
We have introduced the new `grid-row` class in order to modernise the layout of
both the subtopic and latest pages.
This makes it look a bit different from the current version live.
This was checked with @alextea
@fofr We've updated the CSS to fix the email signup page.
In the process, we also fixed the latest page and came across other issues. Together with @alextea we changed a few things in topic and latest pages (e.g. the width of the from organisations). We introduced the grid-row class there and it does look a bit different, but now uses the new CSS we should be using.
We have also started using standard measurements in some places (e.g. padding in titles) instead of hardcoded pixels. This will explain some of the differences you will see in the wraith output.
Here are the latest tests: https://carvil.github.io/collections-wraith-tests/shots/gallery.html
What do you think?
Looks like the 'is anything wrong' is misaligned now
@nickcolley That's a known issue with government-frontend too. It's a tricky one that I think is acceptable for this PR.
@fofr / @nickcolley the issue with the "Is there anything wrong with this page?" div comes from static and govuk_frontend_toolkit I think.
The wrapper div extends %site-width-container, which in turn adds left/right margin of size $gutter in the tablet viewport (more details here).
I don't think this issue should be fixed in this PR.
Are you ok to merge this change?