Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use components and component guide #385

Merged
merged 7 commits into from Sep 26, 2017
Merged

Use components and component guide #385

merged 7 commits into from Sep 26, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 26, 2017

  • Use govuk_publishing_components gem to generate guide
  • Mount at /component-guide and indicate presence at startup
  • Include minutest integration tests for automated accessibility testing

Components:

  • Use pagination component on latest lists
  • Use title component on email signup pages
  • Use metadata component on subtopics
  • Create topic list component

Pagination

Before

screen shot 2017-09-26 at 11 21 35

After

screen shot 2017-09-26 at 11 21 24

Metadata

Before

screen shot 2017-09-26 at 11 19 18

After

screen shot 2017-09-26 at 11 19 02

Component guide

topic_list

fofr added 4 commits Sep 25, 2017
* Use govuk_publishing_components gem to generate guide
* Mount at /component-guide and indicate presence at startup
* Include minutest integration tests for automated accessibility testing
* Remove old pagination markup, styles and images
* Use component and update tests to reference slimmer’s stubbed HTML
@fofr fofr requested a review from nickcolley Sep 26, 2017
@vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Sep 26, 2017

Have you got links for pages with the pagination and metadata changes?

Copy link
Contributor

@nickcolley nickcolley left a comment

This is awesome!

I've tested the pages you've supplied above before and after (locally) + the guide in Chrome.

@@ -0,0 +1,15 @@
require 'integration_test_helper'

This comment has been minimized.

@nickcolley

nickcolley Sep 26, 2017
Contributor

Should we have a specific test for the new component?

This comment has been minimized.

@fofr

fofr Sep 26, 2017
Author Contributor

Tests added in 35ef5ef

fofr added 3 commits Sep 26, 2017
Create first app component

Refactor each topic list to use the component with a list of items and
tracking data attributes. There’s some duplication with the analytics.
* Keep analytics logic in helper
* Create tracking attributes object with shared properties and merge in
link specific parts when creating topic list for component
* Split out topic_list_tracking_attributes and
topic_list_item_tracking_attributes to allow the see more link to use
those methods on group pages. Keeping attributes the same.
* Add `base_path` method to ExampleLink to match API of other topic
links
@fofr fofr force-pushed the component-guide branch to cf3088d Sep 26, 2017
@fofr fofr merged commit 1977e2d into master Sep 26, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new issues
Details
@fofr fofr deleted the component-guide branch Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.