Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use title components #387

Merged
merged 5 commits into from Oct 2, 2017
Merged

Use title components #387

merged 5 commits into from Oct 2, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 29, 2017

Depends on alphagov/static#1160 being merged and deployed

  • Switch from bespoke title rendering to the static component
  • Keep titles consistent with the rest of GOV.UK

Part of https://trello.com/c/ec0YjgQ4/

Paths to check:

/education
/topic/business-tax/vat
/topic/business-tax/vat/latest
/government/organisations/environment-agency/services-information
fofr added 5 commits Sep 29, 2017
Use margin feature added in alphagov/static#1142
The page-header class isn’t used on taxons
Class was removed in a0ba50
* Add margin helper mixins used on government-frontend
@fofr fofr changed the title [Do not merge] Use title components Use title components Oct 2, 2017
@fofr fofr requested a review from vanitabarrett Oct 2, 2017
@vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Oct 2, 2017

Looks good 👍 The only big change is:

screen shot 2017-10-02 at 13 46 12

screen shot 2017-10-02 at 13 45 53

The 'VAT' context seems a little less obvious, but as it follows the pattern of other titles on GOV.UK, perhaps this won't have a negative effect.

@fofr fofr merged commit c382bf8 into master Oct 2, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the title-components branch Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.