Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid breadcrumbs aria role #237

Merged
merged 1 commit into from Jun 3, 2016
Merged

Remove invalid breadcrumbs aria role #237

merged 1 commit into from Jun 3, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 25, 2016

role="breadcrumbs" is not a thing.
https://www.w3.org/TR/wai-aria/roles#role_definitions

We previously removed from the component:
alphagov/static#737

`role="breadcrumbs"` is not a thing.
https://www.w3.org/TR/wai-aria/roles#role_definitions

We previously removed from the component:
alphagov/static#737
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jun 3, 2016

Thanks @fofr LGTM 👍

@nickcolley nickcolley merged commit c58ec83 into master Jun 3, 2016
1 check passed
1 check passed
default "Build #364 succeeded on Jenkins"
Details
@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 3, 2016

@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jun 3, 2016

@fofr sweet thanks, (stop checking github! :P 🌴 😎 )

@rubenarakelyan rubenarakelyan deleted the remove-invalid-role branch Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.