Render breadcrumbs using the govuk_component #67

Merged
merged 1 commit into from Jan 11, 2017

Projects

None yet

3 participants

@klssmith
Contributor
klssmith commented Jan 11, 2017 edited
  • There is no change to the appearance or text of the breadcrumbs, but
    they are now rendered by the govuk_component.

Trello card

Before (full width and mobile width)

screen shot 2017-01-11 at 12 39 23
screen shot 2017-01-11 at 12 40 04

After (full width and mobile width)

screen shot 2017-01-11 at 12 37 18
screen shot 2017-01-11 at 12 37 47

https://trello.com/c/7wohUbyo

@fofr
Member
fofr commented Jan 11, 2017

Could you include some screenshots of before and after?

Please include mobile widths – we've seen bugs with the breadcrumb component at thin viewports here: alphagov/collections#210

@klssmith klssmith Render breadcrumbs using the govuk_component
- There is no change to the appearance or text of the breadcrumbs, but
they are now rendered by the govuk_component.

Trello: https://trello.com/c/TekeTJ9Y/401-use-govuk-component-in-contacts-frontend
633dc40
@klssmith
Contributor

Thanks @fofr - I've added the screenshots and changed the commit message to make it clearer that the breadcrumbs should look the same before and after (it's just the way they are rendered that has changed).

@tijmenb

Great!

@fofr
fofr approved these changes Jan 11, 2017 View changes
@tijmenb tijmenb merged commit d8adadf into master Jan 11, 2017

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details
@tijmenb tijmenb deleted the use-govuk-component-in-contacts-frontend branch Jan 11, 2017
@tijmenb tijmenb referenced this pull request in alphagov/static Jan 11, 2017
Merged

Remove related links & breadcrumb #879

@rubenarakelyan rubenarakelyan added a commit that referenced this pull request Jan 16, 2017
@rubenarakelyan rubenarakelyan Update domains used for schema tests
As of #67, `slimmer` now requests locale data, which is stubbed out in the tests using `stub_shared_component_locales`. This method stubs all calls to `gov.uk` domains, while the schema test runner still uses the old `alphagov.co.uk` domains. Due to this, schema tests are not passing.
97f3464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment