Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove business finder, facet groups and facets #1053

Merged
merged 35 commits into from Feb 17, 2020
Merged

Conversation

@huwd
Copy link
Contributor

huwd commented Feb 14, 2020

Trello: https://trello.com/c/MG1iAY1p/509-remove-business-readiness-finder-and-supporting-features-from-content-tagger

We should remove, not only the business finder but also the entire group-facets feature.

Example deployed to integration:
https://content-tagger.integration.publishing.service.gov.uk/taxons?asdfas

@huwd

This comment has been minimized.

Copy link
Contributor Author

huwd commented Feb 14, 2020

Managed to get myself in a git-pickle, so this PR replaces this one:
#1050

@huwd huwd changed the title Remove business finder again Remove business finder, facet groups and facets Feb 14, 2020
huwd added 27 commits Feb 13, 2020
and a view that consumes it along with some tag types
Perhaps one to squash here, initially i'd thought we'd just be removing group tagging, but it seems like there's not much left of the facet feature in here right now, so i'm removing more docs
@huwd huwd force-pushed the remove-business-finder-again branch from c98a98b to 8281e6e Feb 14, 2020
* master:
  Migrate publishing api service to GdsApi::PublishingApi from GdsApi::PublishingApiV2
  Update publishing_api_has_links_for_content_ids to stub_publishing_api_has_links_for_content_ids
  Fix rubocop errors resulting from test replacement
  Update publishing_api_does_not_have_item to stub_publishing_api_does_not_have_item
  Update content_store_has_item to stub_content_store_has_item
  Update publishing_api_has_linked_items to stub_publishing_api_has_linked_items
  Update publishing_api_has_links to stub_publishing_api_has_links
  Update publishing_api_has_linkables to stub_publishing_api_has_linkables
  Update publishing_api_has_lookups to stub_publishing_api_has_lookups
  Update publishing_api_has_expanded_links to stub_publishing_api_has_expanded_links
  Update publishing_api_has_content to stub_publishing_api_has_content
  Update test publishing_api_has_item() to stub_publishing_api_has_item()
  Update TestHelpers::PublishingApiV2 to TestHelpers::PublishingApi
@huwd huwd requested review from koetsier, laurentqro and vanitabarrett Feb 14, 2020
@huwd

This comment has been minimized.

Copy link
Contributor Author

huwd commented Feb 17, 2020

@laurentqro you're a hero for wading through that massive pile of commits, thank you!

@huwd huwd merged commit 32e9d68 into master Feb 17, 2020
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the remove-business-finder-again branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.