New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheduled debate date to awaiting debate petitions view #456

Merged
merged 4 commits into from Apr 22, 2016

Conversation

Projects
None yet
2 participants
@leandroalemao
Contributor

leandroalemao commented Apr 14, 2016

Hi people,

I've added the debate schedule date to the awaiting debate petitions view. Useful to check the debate date before clicking on the petition.

image

@pixeltrix

This comment has been minimized.

Show comment
Hide comment
@pixeltrix

pixeltrix Apr 14, 2016

Contributor

Other than the comments it looks 👍

@henryhadlow do we want to do relative dates, eg. 'To be debated today', 'To be debated tomorrow' ?

Contributor

pixeltrix commented Apr 14, 2016

Other than the comments it looks 👍

@henryhadlow do we want to do relative dates, eg. 'To be debated today', 'To be debated tomorrow' ?

@leandroalemao

This comment has been minimized.

Show comment
Hide comment
@leandroalemao

leandroalemao Apr 14, 2016

Contributor

@pixeltrix tks for replying..

I agree.. and I'm making the changes right now and waiting for @henryhadlow reply.

👍

Contributor

leandroalemao commented Apr 14, 2016

@pixeltrix tks for replying..

I agree.. and I'm making the changes right now and waiting for @henryhadlow reply.

👍

@pixeltrix pixeltrix merged commit 077ced0 into alphagov:master Apr 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pixeltrix

This comment has been minimized.

Show comment
Hide comment
@pixeltrix

pixeltrix Apr 22, 2016

Contributor

@leandroalemao thanks!

Contributor

pixeltrix commented Apr 22, 2016

@leandroalemao thanks!

@leandroalemao

This comment has been minimized.

Show comment
Hide comment
@leandroalemao

leandroalemao Apr 22, 2016

Contributor

@pixeltrix, I'm glad to see you've merged my pull request.. 👍 😄 I'm willing to contribute more and more. Tks!

Contributor

leandroalemao commented Apr 22, 2016

@pixeltrix, I'm glad to see you've merged my pull request.. 👍 😄 I'm willing to contribute more and more. Tks!

@pixeltrix

This comment has been minimized.

Show comment
Hide comment
@pixeltrix

pixeltrix Apr 24, 2016

Contributor

@leandroalemao it was a pleasure - if you're looking for something else to work on then #450 is a nice and easy one but if you're looking for something a bit deeper then #458 should be interesting. Feel free to ask questions if you need anything clarifying.

Contributor

pixeltrix commented Apr 24, 2016

@leandroalemao it was a pleasure - if you're looking for something else to work on then #450 is a nice and easy one but if you're looking for something a bit deeper then #458 should be interesting. Feel free to ask questions if you need anything clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment