New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply theme colour to mobile Chrome user interface #652
Conversation
@pixeltrix this will be hard to view locally, could we merge and check on preview please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willp-bl if you can get these changes done I'll deploy it to our preview site and get Pete to have a look.
app/views/layouts/admin.html.erb
Outdated
@@ -9,6 +9,8 @@ | |||
<%= yield :js %> | |||
<meta name="viewport" content="width = device-width" /> | |||
<meta name="robots" content="noindex" /> | |||
<%# theme-color is from app/assets/stylesheets/petitions/_colours.scss:$house-of-commons-green %> | |||
<meta name="theme-color" content="#080"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willp-bl this only applies to home page style web apps right? No-one is going to be adding the admin site to their phone's home page since it doesn't really work on mobile so you might as well remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be visible in the normal mobile chrome browser when you look at any admin pages there, same as the screenshots above, let me know if you still want it removed
@@ -19,6 +19,8 @@ | |||
<% if noindex_page? %> | |||
<meta name="robots" content="noindex" /> | |||
<% end %> | |||
<%# theme-color is from app/assets/stylesheets/petitions/_colours.scss:$house-of-commons-green %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the comment is really necessary - can you remove it please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
Note: I've not actually tested this but it is a small enough change
I've removed the code comments as requested, thanks for reviewing 👍 |
@yahoopete I've put this on https://preview.epetitions.website - if you can find someone with an Android phone and add it to their home screen you can see what it looks like. |
Yep - I have said Android phone... looks great.
…On Thu, 29 Nov 2018 at 09:41, Andrew White ***@***.***> wrote:
@yahoopete <https://github.com/yahoopete> I've put this on
https://preview.epetitions.website - if you can find someone with an
Android phone and add it to their home screen you can see what it looks
like.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#652 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABsg6vVilgu4p8cKXO96CBx3WA72Et0Fks5uz6uwgaJpZM4T-fac>
.
|
Note: I've not actually tested this but it is a small enough change