Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply theme colour to mobile Chrome user interface #652

Merged
merged 1 commit into from Nov 29, 2018

Conversation

willp-bl
Copy link
Contributor

Note: I've not actually tested this but it is a small enough change

@yahoopete
Copy link
Contributor

@pixeltrix this will be hard to view locally, could we merge and check on preview please?

@willp-bl
Copy link
Contributor Author

willp-bl commented Jun 1, 2018

Screenshots:

 

Copy link
Contributor

@pixeltrix pixeltrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willp-bl if you can get these changes done I'll deploy it to our preview site and get Pete to have a look.

@@ -9,6 +9,8 @@
<%= yield :js %>
<meta name="viewport" content="width = device-width" />
<meta name="robots" content="noindex" />
<%# theme-color is from app/assets/stylesheets/petitions/_colours.scss:$house-of-commons-green %>
<meta name="theme-color" content="#080">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willp-bl this only applies to home page style web apps right? No-one is going to be adding the admin site to their phone's home page since it doesn't really work on mobile so you might as well remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be visible in the normal mobile chrome browser when you look at any admin pages there, same as the screenshots above, let me know if you still want it removed

@@ -19,6 +19,8 @@
<% if noindex_page? %>
<meta name="robots" content="noindex" />
<% end %>
<%# theme-color is from app/assets/stylesheets/petitions/_colours.scss:$house-of-commons-green %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the comment is really necessary - can you remove it please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Note: I've not actually tested this but it is a small enough change
@willp-bl
Copy link
Contributor Author

I've removed the code comments as requested, thanks for reviewing 👍

@pixeltrix pixeltrix merged commit 4e62f26 into alphagov:master Nov 29, 2018
@pixeltrix
Copy link
Contributor

@yahoopete I've put this on https://preview.epetitions.website - if you can find someone with an Android phone and add it to their home screen you can see what it looks like.

@yahoopete
Copy link
Contributor

yahoopete commented Nov 29, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants