Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to rename brexit related subscriber list titles #1020

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@koetsier
Copy link
Contributor

koetsier commented Nov 1, 2019

Adds a migration to rename Brexit related subscriber list titles

Trello card: https://trello.com/c/dhHPa8eK/201-pre-election-changes-to-brexit-checker-notification-emails

Copy link
Contributor

benthorner left a comment

Migration looks good 👍 . Do we have a precedent for spec testing migrations elsewhere? Since we're only going to run it once, could we just try it on integration or locally?

@huwd
huwd approved these changes Nov 1, 2019
@koetsier koetsier force-pushed the rename_titles branch from d0a85e4 to a759896 Nov 1, 2019
@koetsier

This comment has been minimized.

Copy link
Contributor Author

koetsier commented Nov 1, 2019

@benthorner We don't really no. I don't mind removing it later (probably makes sense to). It was just for my own peace of mind

@koetsier koetsier force-pushed the rename_titles branch 3 times, most recently from 1caade0 to 8f5cb2b Nov 1, 2019
@koetsier koetsier force-pushed the rename_titles branch from 8f5cb2b to c76e9b6 Nov 1, 2019
@koetsier koetsier merged commit 09ba3a5 into master Nov 1, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/security No security issues found
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.