Rebuild API service as standard Rails app #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents issues with unloading in development.
Matches the existing API.
This allows us to fall back to current user in development and test environments.
In production-like environments this is created by Puppet; in development and test we'll have `sudo` so run the command explicitly ourselves.
This adds a master CI build script and a branch building script.
This allows us to run it in the default Rake task.
Closed
bradwright
force-pushed
the
rebuild-rebased
branch
2 times, most recently
from
c04115d
to
d57dd82
Compare
Paired with @rboulton. We now check that we have all the keys rather than an overlapping subset of them, and use this in `where_tags_equal`. Also add passing tests of SubscriberList.with_at_least_one_tag_of_each_type to narrow down its behaviour a bit more, and tests of SubscriberList.where_tags_equal, which fail in some cases.
bradwright
force-pushed
the
rebuild-rebased
branch
from
d57dd82
to
3f90b96
Compare
james
added a commit
that referenced
this pull request
Oct 29, 2014
Rebuild API service as standard Rails app
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Replaces #34 - this is a rebase/reorder of the work in that branch to be better about preserving history.
While hexagonal architecture is fine in principle, the complexity of the abstraction was getting in the way of delivering important bugs/features, namely:
This pull request, almost entirely by @elliotcm, rewrites the application as a standard Rails application, and as a bonus implements queuing using Sidekiq and fixes the topic bug.
Note: this will require merging a separate PR in gds-api-adapters to fix the URL namespacing that's changed (from underscore separated to dash-separated), and careful deployment (we'll want to wipe the database before deploying, as the migrations and schema have changed).
I recommend checking out the code and running it to test this - reading the diff is going to be hairy.