Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Official Documents Finder #1154
This PR allows finder front end to render an Official Documents Finder.
It displays a pre-filtered list of documents that return
Search page examples to sanity check:
bilbof left a comment
I think we can make this code more generic. Could we define a single class (for filter and for facet) and pass in the difference as arguments?
It looks like
I'd remove the duplicated code now, while we're very familiar with it. Future us might forget how this stuff works.
If we can extract the duplicated stuff into additional classes that will make future changes easier.
For example, since the only difference between
I would also see - this might be out of scope for this PR - if