Add is_historic and government_name to fields requested from search #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrucadu
force-pushed
the
msw/history-mode
branch
from
d37657a
to
0305fc4
Compare
barrucadu
force-pushed
the
msw/history-mode
branch
from
0305fc4
to
71c3c5f
Compare
barrucadu
force-pushed
the
msw/history-mode
branch
from
71c3c5f
to
ca95055
Compare
barrucadu
force-pushed
the
msw/history-mode
branch
from
ca95055
to
546e48e
Compare
This was referenced Jun 17, 2019
|
This will have a merge conflict with #1197 |
The "first published under the X government" feature is currently broken because we're not getting this metadata.
barrucadu
force-pushed
the
msw/history-mode
branch
from
546e48e
to
84ce3ca
Compare
bilbof
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "first published under the X government" feature is currently
broken because we're not getting this metadata.
There's dead code in the rummager URL helpers (and possibly other parts of the feature tests) which I'll remove in a follow-up PR.
Search page examples to sanity check:
http://finder-frontend-pr-1198.herokuapp.com/search/all?parent=&keywords=%22every+child+matters%22&level_one_taxon=&manual=&public_timestamp%5Bfrom%5D=&public_timestamp%5Bto%5D=&order=relevance
Other finders
Trello card