Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back spelling suggestions #1554

Closed
wants to merge 5 commits into from

Conversation

@kr8n3r
Copy link
Contributor

commented Sep 13, 2019

Coauthored with @SamJamCul

Back by popular demand!

We used to have spelling suggestions. We blogged about them as well

This works enables spelling suggestions on search/all finder only.

Screen Shot 2019-09-13 at 15 43 12

Changes made to design
image

image

TODO:

  • implement analytics tests

URLs to test
Present on https://finder-frontend-pr-1554.herokuapp.com/search/all
Not present on https://finder-frontend-pr-1554.herokuapp.com/cma-cases

Trello ticket: https://trello.com/c/fCavIyMo/888-bring-back-spelling-suggestions

@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 13, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 13, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from ebecdba to c156fed Sep 13, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 13, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 13, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from ebab1f8 to f5df976 Sep 13, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 13, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from f5df976 to d171a03 Sep 14, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 14, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 15, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from f7ad102 to d171a03 Sep 15, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 15, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from d171a03 to f162cfb Sep 15, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 15, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from f162cfb to 60d52dd Sep 15, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 15, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 16, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 0886d0b to 118a32b Sep 16, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 16, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 118a32b to 406b107 Sep 16, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 16, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 406b107 to f438002 Sep 17, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 17, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from f438002 to 373d98f Sep 17, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 17, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 17, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 8963aa0 to 3dc3cf5 Sep 17, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 17, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 17, 2019 Inactive
Copy link
Member

left a comment

Generally looks good. I've left some comments regarding the way SCSS is written.

app/assets/stylesheets/finder_frontend.scss Outdated Show resolved Hide resolved
app/assets/javascripts/live_search.js Outdated Show resolved Hide resolved
app/assets/stylesheets/finder_frontend.scss Outdated Show resolved Hide resolved
app/views/finders/_sort_options.html.erb Outdated Show resolved Hide resolved
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 24, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 651afc4 to d0b8510 Sep 25, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 25, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from d0b8510 to 995fe1a Sep 25, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 25, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 995fe1a to 5b724cf Sep 26, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 26, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 5b724cf to 3d247ab Sep 26, 2019
@bevanloon bevanloon had a problem deploying to finder-frontend-pr-1554 Sep 26, 2019 Failure
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 3d247ab to 923113a Sep 26, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 26, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 923113a to de7b5f5 Sep 27, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 27, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from de7b5f5 to 643552c Sep 27, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 27, 2019 Inactive
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from 643552c to aa05654 Sep 27, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Sep 27, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Oct 2, 2019 Inactive
kr8n3r added 4 commits Sep 13, 2019
Show/hide spelling suggestion block and suggestions based on their
availability server-side.

Each suggestion string comes with a link, so we output it for the user
to click and re-perform the search.
Update other elements to match new designs

Server-side we add a CSS class that if there are any suggestions on
user query, we show the suggestions block.
By default it is hidden.
Because we use ajax to fetch new data when user performs a search or
adds/removes filters, we also need to show any available suggestions.

As the suggestion block is always there we show or hide it and insert
new suggestion links.

This only runs on search/all finder.
@kr8n3r kr8n3r force-pushed the bring-back-spelling-suggestions branch from aa05654 to 2f7bbc3 Oct 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1554 Oct 3, 2019 Inactive
If suggestions exist we fire a custom dimension
and custom impressions.
If a suggestion is clicked we record that into a separate list.
@kr8n3r

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2019

closing in favour of #1643 as we're going to revisit work to do more on the application side and less in JavaScript

@kr8n3r kr8n3r closed this Oct 10, 2019
@kr8n3r kr8n3r deleted the bring-back-spelling-suggestions branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.