Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation describing changes in PR #1604 #1612

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@huwd
Copy link
Contributor

commented Oct 1, 2019

Updated dev documentation to cover changes in #1604

A part of: https://trello.com/c/fMFEA6y9/294-send-separate-notifications-when-criteria-change

@huwd huwd requested a review from benthorner Oct 1, 2019
@huwd huwd self-assigned this Oct 1, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1612 Oct 1, 2019 Inactive
Copy link
Collaborator

left a comment

Looks good 👍. Just a couple of minor comments.

docs/make-changes-to-brexit-checker-content.md Outdated Show resolved Hide resolved
docs/make-changes-to-brexit-checker-content.md Outdated Show resolved Hide resolved
aka, the one where we let you identify a subset of subscribers when there are criteria changes
@huwd huwd force-pushed the document-criteria-roles-change branch from 7aa4e04 to 9a5c528 Oct 2, 2019
@huwd huwd merged commit 33bfad9 into master Oct 2, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the document-criteria-roles-change branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.