Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T064 #1615

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@huwd
Copy link
Contributor

commented Oct 2, 2019

Relates to: https://trello.com/c/1lvJh9Zi/297-t064-new-haulier-handbook-dft

Please note, this is a first content change PR from me!
Ruthless scrutiny appreciated.
I can confirm bundle exec rspec spec/integration/brexit_checker_spec.rb passes.

Questions:

T064 ticket seems to have a different template to previous T086 Ticket. T086 specifically asks if users should be notified. There is no yes or no on this ticket.

  • Has there been a new standard template created since T086?
  • Is the absence of notification proof that we don't need one or should we always ask?
@huwd huwd requested review from thomasleese and emmabeynon Oct 2, 2019
@huwd huwd self-assigned this Oct 2, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1615 Oct 2, 2019 Inactive
Copy link
Collaborator

left a comment

Looks good @huwd - just a stray change to get rid of before this goes in.

lib/brexit_checker/actions.yaml Outdated Show resolved Hide resolved
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1615 Oct 2, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1615 Oct 2, 2019 Inactive
change minor missing full stop

Revert change to T033
Copy link
Collaborator

left a comment

Looks good 👍

@huwd huwd merged commit 66006fe into master Oct 3, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.