Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change criteria for S011 #1624

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@huwd
Copy link
Contributor

commented Oct 3, 2019

A part of: https://trello.com/c/OBc5NGTY/304-s011-uk-change-criteria-to-nationality-uk-and-visiting-eu

@benthorner and I have tested by subscribing on integration him to:

  • nationality-uk
  • visiting-eu

and he's confirmed that after running the task on integration he has not recieved an email.

@huwd huwd requested a review from benthorner Oct 3, 2019
@huwd huwd self-assigned this Oct 3, 2019
@huwd huwd changed the title change remove criteria for S011 change criteria for S011 Oct 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1624 Oct 3, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1624 Oct 4, 2019 Inactive
@huwd huwd force-pushed the SO11-change branch from 02e8697 to 4f60de0 Oct 4, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1624 Oct 4, 2019 Inactive
@huwd huwd requested a review from koetsier Oct 4, 2019
@huwd huwd changed the title change criteria for S011 Change criteria for S011 Oct 4, 2019
@huwd huwd force-pushed the SO11-change branch from 4f60de0 to 09dcc09 Oct 4, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1624 Oct 4, 2019 Inactive
Copy link
Collaborator

left a comment

Looks good. We should be sure to test the notification in integration, since this will be the first time we've used the criteria override feature.

@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1624 Oct 7, 2019 Inactive
@huwd huwd force-pushed the SO11-change branch from 282428b to a375543 Oct 7, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1624 Oct 7, 2019 Inactive
@huwd huwd force-pushed the SO11-change branch from a375543 to 11eb0a7 Oct 7, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1624 Oct 7, 2019 Inactive
@huwd huwd force-pushed the SO11-change branch from 11eb0a7 to faa0d10 Oct 7, 2019
@huwd huwd merged commit b63be14 into master Oct 7, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the SO11-change branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.