Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change business finder title to reflect current question #1631

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@huwd
Copy link
Contributor

commented Oct 4, 2019

Relates to: https://trello.com/c/7RccsHQ2/306-change-business-finder-page-titles-to-match-the-question-being-shown

I wasn't sure how or why the previous title was being used from qa_config['title'], so i left it in as a fallback in case this view also renders something which doesn't have a current_facet

@huwd huwd self-assigned this Oct 4, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1631 Oct 4, 2019 Inactive
@huwd huwd requested a review from benthorner Oct 4, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1631 Oct 4, 2019 Inactive
I wasn't sure how or why the previous title was being used from qa_config['title'], so i left it in as a fallback in case this view also renders something which doesn't have a current_facet

relates to: https://trello.com/c/7RccsHQ2/306-change-business-finder-page-titles-to-match-the-question-being-shown
Copy link
Collaborator

left a comment

👍

@huwd huwd changed the title Change business finder title to reflect current question [DO NOT MERGE] Change business finder title to reflect current question Oct 7, 2019
@huwd huwd changed the title [DO NOT MERGE] Change business finder title to reflect current question Change business finder title to reflect current question Oct 8, 2019
@huwd huwd merged commit c489315 into master Oct 8, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the biz-finder-add-title branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.