Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flourinated-gas registration service url #1644

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@huwd
Copy link
Contributor

commented Oct 10, 2019

The link without the path works, but the user is redirected to /register/index, however we appear to be appending google analytics ids as optional params to URLS when making this hop. If the param is appended to the root it causes a failure of the gas registration app. However if the param is appended to /register, everything continues to work.

Q. Might we have this problem on any other actions that link to other gov services?
Q. What's the deal with this GA stuff?

The link without the path works, but the user is redirected to /register/index, however we appear to be appending google analytics ids as optional params to URLS when making this hop. If the param is appended to the root it causes a failure of the gas registration app. However if the param is appended to /register, everything continues to work
Copy link
Collaborator

left a comment

Good spot 👍

@huwd huwd merged commit 4278dd3 into master Oct 10, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the fix-fgas-link branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.