Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Audience headers rendering without content #1718

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@huwd
Copy link
Contributor

huwd commented Nov 5, 2019

I introduced a bug in #1714
The view layer was only filtering by any action, it is now more nuanced and filters on a per-group basis, that fits the new data structure.

Screen Shot 2019-11-05 at 3 07 53 PM

Also wrote some tests.

@huwd huwd requested review from benthorner, vanitabarrett and koetsier Nov 5, 2019
when_i_visit_the_brexit_checker_flow
and_i_answer_citizen_questions
and_i_answer_business_questions
then_i_should_see_the_results_page
and_i_should_see_the_citizens_action_header

This comment has been minimized.

Copy link
@benthorner

benthorner Nov 5, 2019

Collaborator

To avoid adding more methods in here, could we look at combining them into a single 'then' step where they 'see_citizen_and_business_results', etc?

This comment has been minimized.

Copy link
@huwd

huwd Nov 5, 2019

Author Contributor

How do these rspec feature tests work, are they just looking for each line to be true?

So you'd use !see_citizen_and_business_results and see_citizen_and_business_results in the main method?

@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1718 Nov 5, 2019 Inactive
@huwd huwd force-pushed the fixHeaderWhenNoResults branch from 33ab25f to 065ff8b Nov 5, 2019
Copy link
Collaborator

benthorner left a comment

👍

@huwd huwd merged commit becd575 into master Nov 5, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the fixHeaderWhenNoResults branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.