Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEA questions and cards #1729

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@huwd
Copy link
Contributor

huwd commented Nov 7, 2019

Trello: https://trello.com/c/SEwQzHzD/230-content-style-change-replacement-of-eea-in-action-cards-and-checker-questions


Changes to both actions and questions in response to user concerns that EEA was not clearly understood by some users.

@huwd huwd requested review from benthorner, emmabeynon and koetsier Nov 7, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1729 Nov 7, 2019 Inactive
@huwd huwd requested a review from vanitabarrett Nov 7, 2019
@huwd huwd force-pushed the EEAQuestionsAndCards branch from a471701 to 1675509 Nov 7, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1729 Nov 7, 2019 Inactive
Copy link
Contributor

emmabeynon left a comment

Just noticed one missing space, otherwise LGTM 👍

lib/brexit_checker/actions.yaml Outdated Show resolved Hide resolved
@huwd huwd force-pushed the EEAQuestionsAndCards branch from 1675509 to 0da48ea Nov 8, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1729 Nov 8, 2019 Inactive
@huwd huwd force-pushed the EEAQuestionsAndCards branch from 0da48ea to f945998 Nov 8, 2019
@huwd huwd merged commit 9b34f39 into master Nov 8, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the EEAQuestionsAndCards branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.