Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[On hold until 13th] - New Results page #1776

Draft
wants to merge 19 commits into
base: master
from

Conversation

@huwd
Copy link
Contributor

huwd commented Dec 2, 2019

Do not merge until post-election


A part of: A part of: https://trello.com/c/uLLaEVPV/186-dont-deploy-update-checker-results-page


Includes

Examples

@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 2, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 2, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 2, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 2, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from cc33864 to d310827 Dec 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from bab2ba9 to bca6cf6 Dec 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from aeaa628 to c35a761 Dec 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from 04efd05 to f829fdc Dec 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from f829fdc to 7b6b332 Dec 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from 7b6b332 to 8420579 Dec 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from dc0a78c to 807fdd9 Dec 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from 807fdd9 to da182e5 Dec 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from da182e5 to 14227f9 Dec 3, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 3, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from 14227f9 to 71af653 Dec 3, 2019
huwd added 5 commits Dec 2, 2019
The data source for actions comes from a spreadsheet, data can be entered there without much validation.
We should therefore treat all data as suspect until proved otherwise. We prove that here, as all citizens actions must appear inside a group, we require a 'grouping_criteria'.
Actions without this should be rejected as invalid.
The results pages are now more complex, they require results to be grouped into audiences, then citizens must be further grouped under subheadings. A particular difficulty is then representing the page criteria against each one of these groups. This new class does all of that with a simple API that allows you to call business and citizens results.
We should now be able to use these in the view instead of actions
Criterion are currently passed to the view as a key, this can be used to translate this into human readable text
@huwd huwd force-pushed the new-results-page branch from 20a6293 to a7f78b2 Dec 6, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 6, 2019 Inactive
huwd added 7 commits Dec 3, 2019
I think it's clearer what's going on if the results page can check for a partial's criteria at the level of results and then conditionally render a partial

Especially given the added complexity that is about to arrive with subgroups
This now appears as a pull quote within the body rather than alongside
Better to consume a group variable that helps identify if we're in business or citizens actions
Where we're going, we won't need these.
@huwd huwd force-pushed the new-results-page branch from a7f78b2 to 041e726 Dec 6, 2019
@bevanloon bevanloon temporarily deployed to finder-frontend-pr-1776 Dec 6, 2019 Inactive
@karlbaker02 karlbaker02 temporarily deployed to finder-frontend-pr-1776 Dec 9, 2019 Inactive
@karlbaker02 karlbaker02 temporarily deployed to finder-frontend-pr-1776 Dec 9, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from abc318a to c9addbf Dec 9, 2019
@karlbaker02 karlbaker02 temporarily deployed to finder-frontend-pr-1776 Dec 9, 2019 Inactive
@karlbaker02 karlbaker02 temporarily deployed to finder-frontend-pr-1776 Dec 9, 2019 Inactive
@karlbaker02 karlbaker02 temporarily deployed to finder-frontend-pr-1776 Dec 9, 2019 Inactive
@huwd huwd force-pushed the new-results-page branch from e197dbf to 2af1700 Dec 9, 2019
@karlbaker02 karlbaker02 temporarily deployed to finder-frontend-pr-1776 Dec 9, 2019 Inactive
huwd added 4 commits Dec 3, 2019
Also renames the file which was mistakenly pluralized
Copied across as a block from an older iteration on this PR it includes the css to

- Style the new header sections as full width for audiences

- Group sections withorizontal rules between

- Style the subheading titles above criteria
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.