Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[On hold until 13th] - New Results page #1776
Do not merge until post-election
A part of: A part of: https://trello.com/c/uLLaEVPV/186-dont-deploy-update-checker-results-page
The data source for actions comes from a spreadsheet, data can be entered there without much validation. We should therefore treat all data as suspect until proved otherwise. We prove that here, as all citizens actions must appear inside a group, we require a 'grouping_criteria'. Actions without this should be rejected as invalid.
The results pages are now more complex, they require results to be grouped into audiences, then citizens must be further grouped under subheadings. A particular difficulty is then representing the page criteria against each one of these groups. This new class does all of that with a simple API that allows you to call business and citizens results.
I think it's clearer what's going on if the results page can check for a partial's criteria at the level of results and then conditionally render a partial Especially given the added complexity that is about to arrive with subgroups
Better to consume a group variable that helps identify if we're in business or citizens actions
Copied across as a block from an older iteration on this PR it includes the css to - Style the new header sections as full width for audiences - Group sections withorizontal rules between - Style the subheading titles above criteria