Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide print link if JS not available #1853

Merged
merged 1 commit into from Jan 10, 2020
Merged

Hide print link if JS not available #1853

merged 1 commit into from Jan 10, 2020

Conversation

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Jan 10, 2020

Trello: https://trello.com/c/JcC2UeYw/354-hide-print-link-if-javascript-is-disabled

What

Hide the print link when JS is disabled.

Why

The print link relies on JS, so doesn't work if JS is not available.

Example

@karlbaker02 karlbaker02 temporarily deployed to finder-frontend-pr-1853 Jan 10, 2020 Inactive
@vanitabarrett vanitabarrett force-pushed the hide-print-no-js branch from 37c6bff to 22d4bfe Jan 10, 2020
@karlbaker02 karlbaker02 temporarily deployed to finder-frontend-pr-1853 Jan 10, 2020 Inactive
The print link relies on JS, so doesn't work if JS is not available. In this case, we should hide the link
@vanitabarrett vanitabarrett force-pushed the hide-print-no-js branch from 22d4bfe to 2f16740 Jan 10, 2020
@vanitabarrett vanitabarrett marked this pull request as ready for review Jan 10, 2020
@vanitabarrett vanitabarrett requested a review from huwd Jan 10, 2020
@huwd
huwd approved these changes Jan 10, 2020
@vanitabarrett vanitabarrett merged commit e22b53c into master Jan 10, 2020
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@vanitabarrett vanitabarrett deleted the hide-print-no-js branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.