Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change show only brexit results to show only transition period results #1911

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@huwd
Copy link
Contributor

huwd commented Feb 3, 2020

Trello: https://trello.com/c/Uanimli2/415-change-brexit-to-transition-period-on-search-checkboxes

News and communications finders have a special checkbox to limit all searches to brexit materials.
The brexit taxon has now been moved to transition. Whilst the check continues to work it is now mis-labelled.

This PR changes these expectations in fixtures so that they match the parallel work in search api, as well as fixing the cucumber tests.

It also takes the opportunity to rename the key from related_to_brexit to related_to_transition_period

@bevanloon bevanloon temporarily deployed to finder-front-update-bre-7tbloj Feb 3, 2020 Inactive
@huwd huwd force-pushed the update-brexit-checkbox-to-transition branch from 324d96e to c335c28 Feb 4, 2020
@bevanloon bevanloon temporarily deployed to finder-front-update-bre-7tbloj Feb 4, 2020 Inactive
@huwd huwd force-pushed the update-brexit-checkbox-to-transition branch from c335c28 to 3f79655 Feb 4, 2020
@bevanloon bevanloon temporarily deployed to finder-front-update-bre-7tbloj Feb 4, 2020 Inactive
@huwd huwd requested review from koetsier and laurentqro Feb 5, 2020
@huwd huwd marked this pull request as ready for review Feb 5, 2020
@@ -89,11 +89,11 @@
"preposition": "about"
},
{
"key": "related_to_brexit",
"key": "related_to_transition_period",

This comment has been minimized.

Copy link
@sihugh

sihugh Feb 5, 2020

Contributor

Are we catering for redirects? We know that people have RSS feeds set up for this, and changing the key will stop these from working unless we do something about it.

This comment has been minimized.

Copy link
@huwd

huwd Feb 5, 2020

Author Contributor

ah... humm.... that's a really good shout and a pain...
Ideally we don't want any user facing references to brexit anymore as all this content should now be about transition.

... can we redirect on a param?

This comment has been minimized.

Copy link
@huwd

huwd Feb 5, 2020

Author Contributor

Humm ok, rolling this back for now in an effort to separate out the content change from the key change.

A checkbox that appears in the news and communciations finder
@huwd huwd force-pushed the update-brexit-checkbox-to-transition branch from 3f79655 to 4d7a8c2 Feb 5, 2020
@bevanloon bevanloon temporarily deployed to finder-front-update-bre-7tbloj Feb 5, 2020 Inactive
@huwd huwd requested a review from sihugh Feb 5, 2020
Copy link
Contributor

koetsier left a comment

looks good

@huwd huwd merged commit fc456fe into master Feb 6, 2020
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the update-brexit-checkbox-to-transition branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.