Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return notifications for T092, T086, T096, T097, S032 #1917

Merged
merged 1 commit into from Feb 5, 2020
Merged

Conversation

@huwd
Copy link
Contributor

huwd commented Feb 5, 2020

We removed a whole bunch of actions as part of the pre-brexit check work.

Finder frontend has some data integrity checks that rightly states there shouldn’t be a notification for an action that doesn’t exist.

In this case there are a bunch of notifications that exist for actions that temporarily do not. They are left commented rather than removed as the data is and will be useful in the future and should shortly be returned.

Periodically I am checking to see which of these actions have returned and am uncommenting the relevant notifications.

In this case, only one notification returns T086.

A part of the work referenced in commit c048c0f
@bevanloon bevanloon temporarily deployed to finder-front-return-not-xiftht Feb 5, 2020 Inactive
@huwd huwd requested review from vanitabarrett and laurentqro Feb 5, 2020
@huwd huwd merged commit 32c8f66 into master Feb 5, 2020
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the return-notifications branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.