Refactor transition checker action tests to be less brittle #1919
On the 30th and 31st we needed to bulk update a range of actions at once. After doing so we discovered some the actions that had been removed were required for tests. This made the process more intensive.
We can have higher degrees of confidence that some actions will remain for the duration of the transition period. The actions with the highest degree of confidence would make good candidates for tests, as they should weather any future changes to actions in the checker.
Those actions are suggested to be:
Also, occasionally when we add new actions they will also match the criteria these tests select for. This will cause new additions to the test's result page, which can lead to changes in order the results are rendered. The data-track-action is a tracking attribute which explicitly records that, current tests with
A better strategy would be to return the string that is found and check that against our expectations, updating them if necessary.
Specifically, switch to using actions we have a higher degree of confdience will remain constants across the next year, also separate the checker for data-track-action out into a separate expects, which will give better expectation mismatch responses if we add new actions that change the position of these tested actions on the results page