Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove facet extractor #1934

Merged
merged 3 commits into from Feb 13, 2020
Merged

Remove facet extractor #1934

merged 3 commits into from Feb 13, 2020

Conversation

@huwd
Copy link
Contributor

huwd commented Feb 12, 2020

Trello: https://trello.com/c/qBM5QLID/482-business-finder-tech-debt

Facet extractor is a piece of tech debt that is no longer needed. Facets are included on the content item and we can dig them out of there.

(this replaces this pr after i overshot on a repace and it rewrote the commit hash IDs)

@bevanloon bevanloon temporarily deployed to finder-front-remove-fac-jkoter Feb 12, 2020 Inactive
@bevanloon bevanloon temporarily deployed to finder-front-remove-fac-jkoter Feb 12, 2020 Inactive
@huwd huwd force-pushed the remove-facet-extractor branch from 53eed72 to cbc3882 Feb 12, 2020
@bevanloon bevanloon temporarily deployed to finder-front-remove-fac-jkoter Feb 12, 2020 Inactive
@bevanloon bevanloon temporarily deployed to finder-front-remove-fac-jkoter Feb 12, 2020 Inactive
@huwd huwd force-pushed the remove-facet-extractor branch from 457c654 to b119fd8 Feb 12, 2020
@bevanloon bevanloon temporarily deployed to finder-front-remove-fac-jkoter Feb 12, 2020 Inactive
@huwd huwd requested review from koetsier and laurentqro Feb 12, 2020
@huwd huwd marked this pull request as ready for review Feb 12, 2020
@huwd huwd requested a review from vanitabarrett Feb 12, 2020
@huwd huwd merged commit 15e4a20 into master Feb 13, 2020
3 checks passed
3 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/publishing-e2e-tests Publishing end-to-end tests succeeded on Jenkins
Details
continuous-integration/jenkins/security No security issues found
Details
@huwd huwd deleted the remove-facet-extractor branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.