Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Heroku review apps #311

Merged
merged 2 commits into from Sep 27, 2017
Merged

Enable Heroku review apps #311

merged 2 commits into from Sep 27, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 26, 2017

Apps will be available at:
https://finder-frontend.herokuapp.com
https://finder-frontend-pr-XXX.herokuapp.com

  • Heroku needs to read ruby version from Gemfile
  • Run the mustache precompile step as part of assets:precompile task on Heroku

Similar to:
alphagov/collections#327

fofr added 2 commits Sep 26, 2017
Apps will be available at:
https://finder-frontend.herokuapp.com
https://finder-frontend-pr-XXX.herokuapp.com

Heroku needs to read ruby version from Gemfile
* Shim the precompile task into the assets:precompile step that Heroku
automatically runs
* The equivalent of
https://github.com/alphagov/govuk-app-deployment/blob/b13ba1ae8be0e0a302
aaacd4990b86f02b422241/finder-frontend/config/deploy.rb#L18-L20
* Running the task after deployment means the generated file gets
cleaned up by Heroku’s ephemeral file system
@fofr fofr requested review from tijmenb and nickcolley Sep 26, 2017
@fofr fofr merged commit bc20b6a into master Sep 27, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new issues
Details
@fofr fofr deleted the heroku-review-apps branch Sep 27, 2017
@nickcolley nickcolley changed the title Enale Heroku review apps Enable Heroku review apps Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.