Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component guide and create date filter component #312

Merged
merged 3 commits into from Sep 28, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 26, 2017

  • Add first component, styles, partial and tests
  • Move date facet into date filter component
  • Enable aria-controls dynamically for component flexibility

In finder

screen shot 2017-09-26 at 18 22 32

Component guide

date filter component - finder frontend component guide 20170926

fofr added 3 commits Sep 26, 2017
As finder-fronted uses RSpec this doesn’t include automated
accessibility testing yet.
* Master was failing locally because of two search boxes on the page
* Add first component, styles, partial and tests
* Move date facet into date filter component
* Enable aria-controls dynamically for component flexibility
@fofr fofr force-pushed the component-guide branch to f50adc6 Sep 27, 2017
@fofr fofr temporarily deployed to finder-frontend-pr-312 Sep 27, 2017 Inactive
Copy link
Contributor

@MatMoore MatMoore left a comment

Cool 👍

Is the idea with data-aria-controls that the relationship only exists when javascript is enabled?

@fofr
Copy link
Contributor Author

@fofr fofr commented Sep 27, 2017

@MatMoore Yes. If the JS is disabled or fails for whatever reason, the inputs won't be controlling another element, so the attributes would be invalid.

@fofr fofr merged commit 8374b04 into master Sep 28, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new issues
Details
@fofr fofr deleted the component-guide branch Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.