Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move option select component to finder-frontend #381

Merged
merged 5 commits into from Jan 15, 2018
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 12, 2018

The option-select component (currently in static) is used only on Finders and Search. The styles and JS don't need to be available on every page.

  • Move static component to finder-frontend (styles, template, docs, images, tests, js and js tests)
  • Update namespace to app-c-option-select (without any further refactoring to classes or HTML, to keep PR small)
  • Update component tests to work with RSpec
  • Update apps to use local component

I recommend reading the PR commit by commit. f89b8da is a direct port, and subsequent commits show how the component was updated to be a local one.

Option select component originally created in alphagov/static#529 for reference.

fofr added 5 commits Jan 12, 2018
`app-c` for component apps, rather than `govuk-` the legacy static
namespace
It’s necessary to include the component twice at the moment – once for
search and once for finders.
@fofr fofr requested review from andysellick and nickcolley Jan 12, 2018
fofr added a commit to alphagov/static that referenced this pull request Jan 12, 2018
The option select component has moved to finder-frontend, closer to its
point of use. See: alphagov/finder-frontend#381

Originally added in #529
Copy link
Contributor

@andysellick andysellick left a comment

Looks okay. How will we make sure that the CSS gets refactored properly in the future?

@fofr fofr merged commit 8d76d40 into master Jan 15, 2018
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the option-select-component branch Jan 15, 2018
fofr added a commit to alphagov/smokey that referenced this pull request Jan 16, 2018
Option select component is now in finder-frontend:
alphagov/finder-frontend#381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.