Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds email subscription to policy papers and consultations finder #929

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@oscarwyatt
Copy link
Contributor

oscarwyatt commented Mar 6, 2019

Adds email subscription to policy papers and consultations finder

Trello: https://trello.com/c/tIXZB4LG/482-make-post-review-changes-to-policy-papers-and-consultations-finder

@benthorner benthorner temporarily deployed to finder-frontend-pr-929 Mar 6, 2019 Inactive

@bilbof
Copy link
Contributor

bilbof left a comment

I think we'll also want to permit filtering the email subscriptions by content_store_document_type as this is possible on the finder.

This might require more changes to support option_lookup in finder facets when signing up for email alerts.

},
"email_filter_by": null,
"email_filter_name": null,
"subscription_list_title_prefix": "Policy papers and consultations ",

This comment has been minimized.

Copy link
@bilbof

bilbof Mar 7, 2019

Contributor

The trailing space is no longer required for subscription_list_title_prefix so lets remove it.

@koetsier
Copy link
Contributor

koetsier left a comment

Amazing! 👍

"description": "You'll get an email each time policy papers and consultations are published.",
"details": {
"filter": {
"content_purpose_supergroup": "policy-papers-and-consultations"

This comment has been minimized.

Copy link
@bilbof

bilbof Mar 8, 2019

Contributor

This needs to be: policy_and_engagement.

"facet_name": "organisations"
},
{
"facet_id": "document_type",

This comment has been minimized.

Copy link
@bilbof

bilbof Mar 8, 2019

Contributor

This'll need to be content_store_document_type, and it should support option_lookup behaviour like the finder (otherwise we'll pass content_store_document_type=policy_papers to email-alert-api when we should be passing content_store_document_type=[impact_assessment,case_study,policy_paper]).

@bilbof

This comment has been minimized.

Copy link
Contributor

bilbof commented Mar 8, 2019

Superseded by #936.

@bilbof bilbof closed this Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.